jubins commented on PR #4410:
URL: https://github.com/apache/flink-cdc/pull/4410#issuecomment-6886262667

   Rebased onto latest `master` (`fc595ab5`) to resolve the conflict with #4418 
(FLINK-39775).
   
   The conflict was a checkpoint-format version collision: #4418 claimed 
version 6 for the snapshot-metadata released flag, and this PR had also claimed 
version 6 for `checkpointIdToFinish`. This rebase introduces version 7, which 
carries both fields: the optional `checkpointIdToFinish` (written first, as a 
presence boolean plus a long when present) followed by the released flag. 
`getVersion()` now always returns 7, since the checkpoint id must be persisted 
in every checkpoint; checkpoints written as versions 5 and 6 remain readable.
   
   @yuxiqian — could you take a look when you have a moment? This has been open 
since May with no review yet, and the stale bot will close it around Dec 1 if 
nothing moves. Happy to address any feedback.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to