rkhachatryan commented on code in PR #29954:
URL: https://github.com/apache/flink/pull/29954#discussion_r4607077214
##########
flink-runtime/src/main/java/org/apache/flink/streaming/runtime/tasks/mailbox/MailboxProcessor.java:
##########
@@ -331,15 +331,16 @@ private void sendPoisonMail(RunnableWithException mail) {
/**
* Sends the given <code>mail</code> with urgent. Intended use is to
control this <code>
- * MailboxProcessor</code>; no interaction with tasks should be performed;
+ * MailboxProcessor</code>; no interaction with tasks should be performed.
The mail is served
+ * before all non-urgent mails, but after urgent mails that are already
pending (FIFO).
Review Comment:
The main issue is that checkpoint mails (urgent) overtake split assignment
mails (non-urgent). In addition to that, there are edge cases when urgent mails
can overtake each other.
Not that urgency is not priority.
##########
flink-runtime/src/main/java/org/apache/flink/streaming/runtime/tasks/mailbox/MailboxProcessor.java:
##########
@@ -331,15 +331,16 @@ private void sendPoisonMail(RunnableWithException mail) {
/**
* Sends the given <code>mail</code> with urgent. Intended use is to
control this <code>
- * MailboxProcessor</code>; no interaction with tasks should be performed;
+ * MailboxProcessor</code>; no interaction with tasks should be performed.
The mail is served
+ * before all non-urgent mails, but after urgent mails that are already
pending (FIFO).
Review Comment:
The main issue is that checkpoint mails (urgent) overtake split assignment
mails (non-urgent). In addition to that, there are edge cases when urgent mails
can overtake each other.
Note that urgency is not priority.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]