rkhachatryan commented on code in PR #29954: URL: https://github.com/apache/flink/pull/29954#discussion_r4607124202
########## flink-runtime/src/main/java/org/apache/flink/streaming/runtime/tasks/mailbox/TaskMailbox.java: ########## @@ -30,6 +30,15 @@ * A task mailbox provides read and write access to a mailbox and has a lifecycle of open -> * (quiesced) -> closed. Mails have a priority that can be used to retrieve only relevant letters. * + * <h3>Priority and urgency</h3> Review Comment: Because the semantic is a bit more complicated than what described: - we have many priorities, not just 2 (priority per operator in the chain + min and max) - read operations take mails with priority at least given (so we'd need to scan multiple queues) - urgency is binary; urgent mails should only overtake non-urgent ones; so we'd need some code that puts the mails in the correct place, etc. This code would be (is today) error-prone -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
