[ 
https://issues.apache.org/jira/browse/FLINK-5690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15865327#comment-15865327
 ] 

ASF GitHub Bot commented on FLINK-5690:
---------------------------------------

Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3300#discussion_r100977226
  
    --- Diff: docs/dev/best_practices.md ---
    @@ -310,3 +310,17 @@ Next, you need to put the following jar files into the 
`lib/` folder:
     Note that you need to explicitly set the `lib/` directory when using a per 
job YARN cluster.
     
     The command to submit Flink on YARN with a custom logger is: `./bin/flink 
run -yt $FLINK_HOME/lib <... remaining arguments ...>`
    +
    +
    +## Resolving Dependency Conflicts with Flink using the maven-shade-plugin.
    --- End diff --
    
    I think this is better for the debugging section
    
    
https://ci.apache.org/projects/flink/flink-docs-release-1.3/monitoring/debugging_classloading.html


> protobuf is not shaded properly
> -------------------------------
>
>                 Key: FLINK-5690
>                 URL: https://issues.apache.org/jira/browse/FLINK-5690
>             Project: Flink
>          Issue Type: Bug
>          Components: Build System
>    Affects Versions: 1.1.4, 1.3.0
>            Reporter: Andrey
>            Assignee: Robert Metzger
>
> Currently distributive contains com/google/protobuf package. Without proper 
> shading client code could fail with:
> {code}
> Caused by: java.lang.IllegalAccessError: tried to access method 
> com.google.protobuf.XXXX
> {code}
> Steps to reproduce:
> * create job class "com.google.protobuf.TestClass"
> * call com.google.protobuf.TextFormat.escapeText(String) method from this 
> class
> * deploy job to flink cluster (usign web console for example)
> * run job. In logs IllegalAccessError.
> Issue in package protected method and different classloaders. TestClass 
> loaded by FlinkUserCodeClassLoader, but TextFormat class loaded by 
> sun.misc.Launcher$AppClassLoader



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to