[
https://issues.apache.org/jira/browse/FLINK-5487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878744#comment-15878744
]
ASF GitHub Bot commented on FLINK-5487:
---------------------------------------
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3358
@rmetzger All of your comments have been addressed, and tests for the new
features have been added (in `ElasticsearchSinkBaseTest`). Can you take another
look? Thanks a lot!
Some notes on changes I made that weren't previously discussed:
1. Renamed `NoOpActionRequestFailureHandler` to just
`NoOpActionFailureHandler` - less of a mouthful ;-)
2. I added the responsed REST status code through the failure handler's
`onFailure(...)` callback. The reason for this is explained in the doc /
Javadoc changes of the last follow-up commit (c594523).
> Proper at-least-once support for ElasticsearchSink
> --------------------------------------------------
>
> Key: FLINK-5487
> URL: https://issues.apache.org/jira/browse/FLINK-5487
> Project: Flink
> Issue Type: Bug
> Components: Streaming Connectors
> Reporter: Tzu-Li (Gordon) Tai
> Assignee: Tzu-Li (Gordon) Tai
> Priority: Critical
>
> Discussion in ML:
> http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/Fault-tolerance-guarantees-of-Elasticsearch-sink-in-flink-elasticsearch2-td10982.html
> Currently, the Elasticsearch Sink actually doesn't offer any guarantees for
> message delivery.
> For proper support of at-least-once, the sink will need to participate in
> Flink's checkpointing: when snapshotting is triggered at the
> {{ElasticsearchSink}}, we need to synchronize on the pending ES requests by
> flushing the internal bulk processor. For temporary ES failures (see
> FLINK-5122) that may happen on the flush, we should retry them before
> returning from snapshotting and acking the checkpoint. If there are
> non-temporary ES failures on the flush, the current snapshot should fail.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
