Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3423#discussion_r103733313
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetTumbleCountWindowAggReduceGroupFunction.scala
---
@@ -85,6 +86,16 @@ class DataSetTumbleCountWindowAggReduceGroupFunction(
}
count += 1
+ // for every maxMergeLen accumulators, we merge them into one
+ if (count % maxMergeLen == 0) {
+ for (i <- aggregates.indices) {
+ val agg = aggregates(i)
+ val accumulator = agg.merge(accumulatorList(i))
--- End diff --
make `accumulatorList` a member of the function and move the initialization
out of `reduce()`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
