Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3423#discussion_r103807487
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -54,31 +58,31 @@ object AggregateUtil {
* organized by the following format:
*
* {{{
- * avg(x) aggOffsetInRow = 2 count(z)
aggOffsetInRow = 5
- * | |
- * v v
- * +---------+---------+--------+--------+--------+--------+
- * |groupKey1|groupKey2| sum1 | count1 | sum2 | count2 |
- * +---------+---------+--------+--------+--------+--------+
+ * avg(x) count(z)
+ * | |
+ * v v
+ *
+---------+---------+-----------------+------------------+------------------+
+ * |groupKey1|groupKey2| AvgAccumulator | SumAccumulator |
CountAccumulator |
+ *
+---------+---------+-----------------+------------------+------------------+
* ^
* |
- * sum(y) aggOffsetInRow = 4
+ * sum(y)
* }}}
*
*/
private[flink] def createPrepareMapFunction(
namedAggregates: Seq[CalcitePair[AggregateCall, String]],
groupings: Array[Int],
inputType: RelDataType)
- : MapFunction[Row, Row] = {
--- End diff --
There are many reformatting changes in this PR. This makes the diffs hard
to read.
Unfortunately, we do not have a fixed code style so we keep changing the
formatting back and forth. IMO, the best approach is to not reformat large
parts of a file because it hides the relevant changes and somebody might just
change it back.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
