Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3484#discussion_r105435806
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/RecordWriterOutput.java
---
@@ -72,6 +76,11 @@ public RecordWriterOutput(
--- End diff --
I can remove the reduplication on `RecordWriterOutput`, `ChainingOutput`
and `CopyingChainingOutput`. Basically those `Outputs` that don't forward to
other outputs but instead push into the operator or into the network. For the
other `Outputs` removing the duplication is not possible because inside the
respective `output()` method they call `output()` of another `Output`. They
call either with an `OutputTag` or without, so the method body is not actually
a duplicate.
I did find another bug, though, where `CopyingBroadcastingOutputCollector`
in `OperatorChain` was not calling the correct `collect()` method on the
downstream `Outputs`. ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
