Github user kl0u commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3484#discussion_r106139449
  
    --- Diff: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorChain.java
 ---
    @@ -387,18 +401,49 @@ public int getChainLength() {
     
                protected final StreamStatusProvider streamStatusProvider;
     
    -           public ChainingOutput(OneInputStreamOperator<T, ?> operator, 
StreamStatusProvider streamStatusProvider) {
    +           protected final OutputTag<T> outputTag;
    +
    +           public ChainingOutput(
    +                           OneInputStreamOperator<T, ?> operator,
    +                           StreamStatusProvider streamStatusProvider,
    +                           OutputTag<T> outputTag) {
                        this.operator = operator;
                        this.numRecordsIn = ((OperatorMetricGroup) 
operator.getMetricGroup()).getIOMetricGroup().getNumRecordsInCounter();
                        this.streamStatusProvider = streamStatusProvider;
    +                   this.outputTag = outputTag;
                }
     
                @Override
                public void collect(StreamRecord<T> record) {
    +                   if (this.outputTag != null) {
    +                           // we are only responsible for emitting to the 
main input
    +                           return;
    +                   }
    +
    +                   pushToOperator(record);
    +           }
    +
    +           @Override
    +           public <X> void collect(OutputTag<?> outputTag, StreamRecord<X> 
record) {
    +                   if (this.outputTag == null || 
!this.outputTag.equals(outputTag)) {
    +                           // we are only responsible for emitting to the 
side-output specified by our
    +                           // OutputTag.
    +                           return;
    +                   }
    +
    +                   pushToOperator(record);
    +           }
    +
    --- End diff --
    
    This can become `private` as the copying alternative has its own 
implementation, right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to