[
https://issues.apache.org/jira/browse/FLINK-6127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932600#comment-15932600
]
ASF GitHub Bot commented on FLINK-6127:
---------------------------------------
GitHub user uce opened a pull request:
https://github.com/apache/flink/pull/3572
[FLINK-6127] [checkstyle] Add MissingDeprecation check
Adds the MissingDeprecation check to our set of checkstyle rules.
Requires every `@Deprecated` annotation to have a `@deprecated` JavaDoc,
forcing us to have both or none. This also applies for internal classes.
Most of the changes were cosmetic (e.g. we had some comments but were not
using the `@deprecated` JavaDoc).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/uce/flink checkstyle_deprecation
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3572.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3572
----
commit 06d70219566a43049f07ff3159f556fe70dbcaec
Author: Ufuk Celebi <[email protected]>
Date: 2017-03-20T10:45:52Z
[FLINK-6127] [checkstyle] Add MissingDeprecation check
commit a1f8b273dc8a662f38ebd92cf092f38f53008d35
Author: Ufuk Celebi <[email protected]>
Date: 2017-03-20T10:57:24Z
[FLINK-6127] [checkstyle] Fix missing @deprecated in flink-core
commit 31377693c0e2ed95f0a6907059c65e21a6d78edf
Author: Ufuk Celebi <[email protected]>
Date: 2017-03-20T11:03:42Z
[FLINK-6127] [checkstyle] Fix missing @deprecated in flink-java
commit de238a72a6920d6a34e6d36b5fdb62b23ab0c4ab
Author: Ufuk Celebi <[email protected]>
Date: 2017-03-20T11:20:38Z
[FLINK-6127] [checkstyle] Fix missing @deprecated in flink-runtime
commit f909ab65f141ad4dcceb48fe616294adda43de53
Author: Ufuk Celebi <[email protected]>
Date: 2017-03-20T12:46:27Z
[FLINK-6127] [checkstyle] Fix missing @deprecated in flink-streaming-java
commit b111cf665abcbb174d43a694f90570dc90c3da62
Author: Ufuk Celebi <[email protected]>
Date: 2017-03-20T12:48:27Z
[FLINK-6127] [checkstyle] Fix missing @deprecated in
flink-statebackend-rocksdb
commit 5532c8bbb02b716a5fd6b6e1d58f712c16ad5b55
Author: Ufuk Celebi <[email protected]>
Date: 2017-03-20T12:50:52Z
[FLINK-6127] [checkstyle] Fix missing @deprecated in flink-table
commit 653a6f2c7848a0311c3ffbdfc3acc193101001c8
Author: Ufuk Celebi <[email protected]>
Date: 2017-03-20T12:55:51Z
[FLINK-6127] [checkstyle] Fix missing @deprecated in
flink-connector-kafka-0.8
commit 83e797d86f1bb8c07cf07b16517eb60bedf355d7
Author: Ufuk Celebi <[email protected]>
Date: 2017-03-20T12:57:55Z
[FLINK-6127] [checkstyle] Fix missing @deprecated in flink-yarn
----
> Add MissingDeprecatedCheck to checkstyle
> ----------------------------------------
>
> Key: FLINK-6127
> URL: https://issues.apache.org/jira/browse/FLINK-6127
> Project: Flink
> Issue Type: Improvement
> Components: Build System
> Reporter: Ufuk Celebi
> Priority: Minor
>
> We should add the MissingDeprecatedCheck to our checkstyle rules to help
> avoiding deprecations without JavaDocs mentioning why the deprecation
> happened.
> http://checkstyle.sourceforge.net/apidocs/com/puppycrawl/tools/checkstyle/checks/annotation/MissingDeprecatedCheck.html
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
