[
https://issues.apache.org/jira/browse/FLINK-6127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932666#comment-15932666
]
ASF GitHub Bot commented on FLINK-6127:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3572#discussion_r106906033
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/table/calcite/rules/FlinkAggregateExpandDistinctAggregatesRule.java
---
@@ -114,15 +114,21 @@ public FlinkAggregateExpandDistinctAggregatesRule(
this.useGroupingSets = useGroupingSets;
}
- @Deprecated // to be removed before 2.0
+ /**
+ * @deprecated to be removed before 2.0
--- End diff --
Doesn't before imply that we remove it in earlier version than 2.0?
> Add MissingDeprecatedCheck to checkstyle
> ----------------------------------------
>
> Key: FLINK-6127
> URL: https://issues.apache.org/jira/browse/FLINK-6127
> Project: Flink
> Issue Type: Improvement
> Components: Build System
> Reporter: Ufuk Celebi
> Priority: Minor
>
> We should add the MissingDeprecatedCheck to our checkstyle rules to help
> avoiding deprecations without JavaDocs mentioning why the deprecation
> happened.
> http://checkstyle.sourceforge.net/apidocs/com/puppycrawl/tools/checkstyle/checks/annotation/MissingDeprecatedCheck.html
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
