[ 
https://issues.apache.org/jira/browse/FLINK-6127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932663#comment-15932663
 ] 

ASF GitHub Bot commented on FLINK-6127:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3572#discussion_r106906116
  
    --- Diff: 
flink-libraries/flink-table/src/main/java/org/apache/flink/table/calcite/rules/FlinkAggregateJoinTransposeRule.java
 ---
    @@ -78,22 +78,34 @@ public FlinkAggregateJoinTransposeRule(Class<? extends 
Aggregate> aggregateClass
                this.allowFunctions = allowFunctions;
        }
     
    -   @Deprecated // to be removed before 2.0
    +   /**
    +    * @deprecated to be removed before 2.0
    --- End diff --
    
    same as above, also multiple times in this file.


> Add MissingDeprecatedCheck to checkstyle
> ----------------------------------------
>
>                 Key: FLINK-6127
>                 URL: https://issues.apache.org/jira/browse/FLINK-6127
>             Project: Flink
>          Issue Type: Improvement
>          Components: Build System
>            Reporter: Ufuk Celebi
>            Priority: Minor
>
> We should add the MissingDeprecatedCheck to our checkstyle rules to help 
> avoiding deprecations without JavaDocs mentioning why the deprecation 
> happened.
> http://checkstyle.sourceforge.net/apidocs/com/puppycrawl/tools/checkstyle/checks/annotation/MissingDeprecatedCheck.html



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to