gyang94 commented on PR #1409: URL: https://github.com/apache/fluss/pull/1409#issuecomment-3155359929
Hi @luoyuxia , pushed a new commit to: 1. fixed warnings and nit. 2. Removed all checks related iceberg's Conversions class. 3. Use `skipEncodeLength`. I think it's ok to have a function with another "encode length" choice, though we don't need it now. 4. For `RowUtils`, I just copied @MehulBatra 's code into this class, to reuse those functions to generate row. Yes we can use `GenericRow.of(value)` to create rows. Nothing different in this case. But I think we can keep this class there, since it uses MemorySegment and create `IndexedRow` type. It is different from GenericRow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
