MehulBatra commented on code in PR #1409: URL: https://github.com/apache/fluss/pull/1409#discussion_r2258150365
########## fluss-common/src/main/java/com/alibaba/fluss/bucketing/IcebergBucketingFunction.java: ########## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package com.alibaba.fluss.bucketing; + +import com.alibaba.fluss.shaded.guava32.com.google.common.hash.HashFunction; +import com.alibaba.fluss.shaded.guava32.com.google.common.hash.Hashing; + +/** An implementation of {@link BucketingFunction} to follow Iceberg's bucketing strategy. */ +public class IcebergBucketingFunction implements BucketingFunction { + + private static final HashFunction MURMUR3 = Hashing.murmur3_32_fixed(); + + @Override + public int bucketing(byte[] bucketKey, int numBuckets) { Review Comment: Although we have bucketKey checks at `FlussBucketingFunction`, should we put check here aswell? ``` if (bucketKey == null || bucketKey.length == 0) { throw new IllegalArgumentException("bucketKey must not be null or empty"); } if (numBuckets <= 0) { throw new IllegalArgumentException("numBuckets must be positive"); } ``` Even if all current fluss integrations pass safe inputs, someone could call IcebergBucketingFunction directly or during tests or future rewrites, subtle bugs are possible what do you guys think? @luoyuxia @gyang94 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
