luoyuxia commented on PR #1409: URL: https://github.com/apache/fluss/pull/1409#issuecomment-3157188640
> Hi @luoyuxia , pushed a new commit to: > > 1. fixed warnings and nit. > 2. Removed all checks related iceberg's Conversions class. > 3. Use `skipEncodeLength`. I think it's ok to have a function with another "encode length" choice, though we don't need it now. > 4. For `RowUtils`, I just copied @MehulBatra 's code into this class, to reuse those functions to generate row. Yes we can use `GenericRow.of(value)` to create rows. Nothing different in this case. > But I think we can keep this class there, since it uses MemorySegment and create `IndexedRow` type. It is different from GenericRow. > wdyt? Thanks for addressing my comments. About 4, I'm just want to avoid add a new utils class for test if not a strong reason. Anyway we can replace it with `GenericRow.of(value)` which is oneline code. Actaully, `IndexedRow` type is not recommended to used now since it's hard to construct a `IndexedRow`, we always recommends users to use generic row in Fluss client to write data. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
