luoyuxia commented on code in PR #1675:
URL: https://github.com/apache/fluss/pull/1675#discussion_r2351714955
##########
fluss-common/src/main/java/org/apache/fluss/config/ConfigOptions.java:
##########
@@ -1401,7 +1401,7 @@ public class ConfigOptions {
public static final ConfigOption<String> KV_LOG_DIR =
key("kv.rocksdb.log.dir")
.stringType()
- .noDefaultValue()
+ .defaultValue("FLUSS_HOME/log/rocksdb")
Review Comment:
Actually, FLUSS_HOME means the directory that you put Fluss, not a really a
path name `FLUSS_HOME`.
##########
fluss-common/src/main/java/org/apache/fluss/config/ConfigOptions.java:
##########
@@ -1401,7 +1401,7 @@ public class ConfigOptions {
public static final ConfigOption<String> KV_LOG_DIR =
key("kv.rocksdb.log.dir")
.stringType()
- .noDefaultValue()
+ .defaultValue("FLUSS_HOME/log/rocksdb")
Review Comment:
https://github.com/apache/fluss/blob/05ab5e86d1df69a96d56beed9ce258c603a478f3/fluss-server/src/main/java/org/apache/fluss/server/kv/rocksdb/RocksDBResourceContainer.java#L286
The parent of `logFilePath` will be `FLUSS_HOME/log`, so you can create a
directory named `FLUSS_HOME/log/rocksdb` and `dbOptions.setDbLogDir` to the dir
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
