rionmonster commented on PR #1675: URL: https://github.com/apache/fluss/pull/1675#issuecomment-3298717226
@luoyuxia I've gone ahead and made the necessary updates. I used the `FileUtils.createDirectory(...)` call to handle the creation of the logging directory as it seemed the most appropriate (and propagating the `throws IOException` to all of the related callers which I didn't love). I'm not sure if there's a preferred way to handle that, but wanted to mention it. Additionally, the documentation update still mentions `FLUSS_HOME/log/rocksdb` which I think is clear, but may be improved (potentially by "$FLUSS_HOME/log/rocksdb" to indicate that the home directory is more dynamic). Open to any thoughts or better approaches around both of these items! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
