luoyuxia commented on code in PR #1675: URL: https://github.com/apache/fluss/pull/1675#discussion_r2354575856
##########
website/docs/maintenance/configuration.md:
##########
@@ -135,7 +135,7 @@ during the Fluss cluster working.
| kv.rocksdb.files.open | Integer | -1
| The maximum number of open files (per bucket of table)
that can be used by the DB, `-1` means no limit. The default value is `-1`.
|
| kv.rocksdb.log.max-file-size | MemorySize | 25mb
| The maximum size of RocksDB's file used for information
logging. If the log files becomes larger than this, a new file will be created.
If 0, all logs will be written to one log file. The default maximum file size
is `25MB`.
|
| kv.rocksdb.log.file-num | Integer | 4
| The maximum number of files RocksDB should keep for
information logging (Default setting: 4).
|
-| kv.rocksdb.log.dir | String | (None)
| The directory for RocksDB's information logging files. If
empty (Fluss default setting), log files will be in the same directory as the
Fluss log. If non-empty, this directory will be used and the data directory's
absolute path will be used as the prefix of the log file name. If setting this
option as a non-existing location, e.g `/dev/null`, RocksDB will then create
the log under its own database folder as before.
|
+| kv.rocksdb.log.dir | String |
FLUSS_HOME/log/rocksdb | The directory for RocksDB's information
logging files. If empty (Fluss default setting), log files will be in the same
directory as the Fluss log. If non-empty, this directory will be used and the
data directory's absolute path will be used as the prefix of the log file name.
If setting this option as a non-existing location, e.g `/dev/null`, RocksDB
will then create the log under its own database folder as before.
|
Review Comment:
Will it better to use `${FLUSS_HOME}/log/rocksdb` instead of
FLUSS_HOME/log/rocksdb?
```suggestion
| kv.rocksdb.log.dir | String |
`${FLUSS_HOME}/log/rocksdb` | The directory for RocksDB's information logging
files. If empty (Fluss default setting), log files will be in the same
directory as the Fluss log. If non-empty, this directory will be used and the
data directory's absolute path will be used as the prefix of the log file name.
If setting this option as a non-existing location, e.g `/dev/null`, RocksDB
will then create the log under its own database folder as before.
|
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
