beryllw commented on code in PR #1915:
URL: https://github.com/apache/fluss/pull/1915#discussion_r2479990169
##########
fluss-client/src/main/java/org/apache/fluss/client/lookup/PrefixKeyLookuper.java:
##########
@@ -146,7 +146,7 @@ private void validatePrefixLookup(TableInfo tableInfo,
List<String> lookupColumn
}
@Override
- public CompletableFuture<LookupResult> lookup(InternalRow prefixKey) {
+ public synchronized CompletableFuture<LookupResult> lookup(InternalRow
prefixKey) {
Review Comment:
Using `synchronized` on the entire `lookup` method might affect client-side
`lookup` efficiency. May be we could narrow the lock scope to only cover
thread-unsafe components instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
