swuferhong commented on code in PR #1915:
URL: https://github.com/apache/fluss/pull/1915#discussion_r2485140366
##########
fluss-client/src/main/java/org/apache/fluss/client/lookup/PrefixKeyLookuper.java:
##########
@@ -146,7 +146,7 @@ private void validatePrefixLookup(TableInfo tableInfo,
List<String> lookupColumn
}
@Override
- public CompletableFuture<LookupResult> lookup(InternalRow prefixKey) {
+ public synchronized CompletableFuture<LookupResult> lookup(InternalRow
prefixKey) {
Review Comment:
> Hi @luoyuxia @platinumhamburg @beryllw some members in lookuper are
stateful, so I agree that there should be some lock protection for those
members.
>
> But what I'm more curious about is: in what scenarios would Flink perform
concurrent lookups using the same lookuper instance? Are there any more
detailed logs available for that particular bug?
Hi, @xx789633. This case occurs during the `tabletServer` restart process
(cluster upgrade). Currently, what I have observed is that it can be stably
reproduced when restarting the `Flink lookup job` during the upgrade. I have
tried to reproduce it in other scenarios, but without success.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
