xx789633 commented on code in PR #1915:
URL: https://github.com/apache/fluss/pull/1915#discussion_r2483739585
##########
fluss-client/src/main/java/org/apache/fluss/client/lookup/PrefixKeyLookuper.java:
##########
@@ -146,7 +146,7 @@ private void validatePrefixLookup(TableInfo tableInfo,
List<String> lookupColumn
}
@Override
- public CompletableFuture<LookupResult> lookup(InternalRow prefixKey) {
+ public synchronized CompletableFuture<LookupResult> lookup(InternalRow
prefixKey) {
Review Comment:
Hi @luoyuxia , I don't think the retry logic would cause concurrent lookups
because the result future defined in `asyncLookup` will only be completed when
the retry fails (with `resultFuture.completeExceptionally`) or successes
(`resultFuture.complete`). In either case, Flink will wait for the result
future to finish before its own retry logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
