wuchong commented on code in PR #2000: URL: https://github.com/apache/fluss/pull/2000#discussion_r2548733236
########## website/docs/engine-flink/delta-joins.md: ########## @@ -145,7 +145,7 @@ The delta join feature is introduced since Flink 2.1 and still evolving, and its Refer to the [Delta Join Issue](https://issues.apache.org/jira/browse/FLINK-37836) for the most up-to-date information. -### Flink 2.1 +### Flink 2.1.2 and later Review Comment: I suggest keeping “Flink 2.1” as the title, but adding a note beneath it, otherwise, it's truly strange we are only linking to a unreleased version, the note can also help users better understand the issue: ``` :::warning There is a known issue ([FLINK-XXXX ](link)) in Flink ≤ 2.1.1 that prevents certain queries from being translated into delta joins. This has been fixed in Flink 2.1.2 and Flink 2.2. ::: ``` ########## website/docs/engine-flink/delta-joins.md: ########## @@ -172,9 +172,9 @@ Refer to the [Delta Join Issue](https://issues.apache.org/jira/browse/FLINK-3783 #### Limitations -- The primary key or the prefix lookup key of the tables must be included as part of the equivalence conditions in the join. +- The primary key or the prefix key of the tables must be included as part of the equivalence conditions in the join. - The join must be a INNER join. -- The downstream nodes of the join can accept duplicate changes, such as a sink that provides UPSERT mode. +- The downstream nodes of the join can accept duplicate changes, such as a sink that provides UPSERT mode without `upsertMaterialize`. Review Comment: It's hard to understand what is a sink without "upsertMaterialize". Could you explain more about this? ########## website/docs/engine-flink/delta-joins.md: ########## @@ -160,7 +160,7 @@ Refer to the [Delta Join Issue](https://issues.apache.org/jira/browse/FLINK-3783 - This is why the option `'table.merge-engine' = 'first_row'` is added to the source table DDL. - All upstream nodes of the join should be `TableSourceScan` or `Exchange`. -### Flink 2.2 (upcoming) +### Flink 2.2.0 and later Review Comment: Just `Flink 2.2` here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
