xuyangzhong commented on code in PR #2000:
URL: https://github.com/apache/fluss/pull/2000#discussion_r2563432527


##########
website/docs/engine-flink/delta-joins.md:
##########
@@ -156,11 +159,13 @@ Refer to the [Delta Join 
Issue](https://issues.apache.org/jira/browse/FLINK-3783
 - The primary key or the prefix key of the tables must be included as part of 
the equivalence conditions in the join.
 - The join must be a INNER join.
 - The downstream nodes of the join can accept duplicate changes, such as a 
sink that provides UPSERT mode without `upsertMaterialize`.
+  - When the pk of the sink does not align with (or does not include) the 
upstream upsert key, the sink will produce a sink materialization (called 
`upsertMaterialize`).
+  - About upsert key and `upsertMaterialize`, more details can be found in 
this 
[blog](https://www.ververica.com/blog/flink-sql-secrets-mastering-the-art-of-changelog-events).

Review Comment:
   I have removed the hint `This node can be disabled by setting 
table.exec.sink.upsert-materialize to NONE.` and add a separate line to explain 
that "the pipeline must discard update-before messages".



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to