xuyangzhong commented on code in PR #2000: URL: https://github.com/apache/fluss/pull/2000#discussion_r2554538958
########## website/docs/engine-flink/delta-joins.md: ########## @@ -172,9 +172,9 @@ Refer to the [Delta Join Issue](https://issues.apache.org/jira/browse/FLINK-3783 #### Limitations -- The primary key or the prefix lookup key of the tables must be included as part of the equivalence conditions in the join. +- The primary key or the prefix key of the tables must be included as part of the equivalence conditions in the join. - The join must be a INNER join. -- The downstream nodes of the join can accept duplicate changes, such as a sink that provides UPSERT mode. +- The downstream nodes of the join can accept duplicate changes, such as a sink that provides UPSERT mode without `upsertMaterialize`. Review Comment: I found that there are no official documents from the Flink side explaining upsert materialization and upsert keys (the related issue https://issues.apache.org/jira/browse/FLINK-23350 is still open). I found an article by Ververica at https://www.ververica.com/blog/flink-sql-secrets-mastering-the-art-of-changelog-events#Fix_the_Issue_with_SinkUpsertMaterializer. I'm not sure if I should include this link here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
