zhaohaidao commented on code in PR #57:
URL: https://github.com/apache/fluss-rust/pull/57#discussion_r2583906513
##########
crates/fluss/src/record/arrow.rs:
##########
@@ -505,6 +520,46 @@ impl<'a> LogRecordBatch<'a> {
change_type: ChangeType::AppendOnly,
})
}
+
+ /// Parse an Arrow IPC message from a byte slice.
+ ///
+ /// Server returns RecordBatch message (without Schema message) in the
encapsulated message format.
+ /// Format: [continuation: 4 bytes (0xFFFFFFFF)][metadata_size: 4
bytes][RecordBatch metadata][body]
+ ///
+ /// This format is documented at:
+ ///
https://arrow.apache.org/docs/format/Columnar.html#encapsulated-message-format
+ ///
+ /// Returns the RecordBatch metadata, body buffer, and metadata version.
+ fn parse_ipc_message(
+ data: &'a [u8],
+ ) -> Option<(arrow::ipc::RecordBatch<'a>, Buffer,
arrow::ipc::MetadataVersion)> {
+ const CONTINUATION_MARKER: u32 = 0xFFFFFFFF;
+
+ if data.len() < 8 {
Review Comment:
followup is tracked here: https://github.com/apache/fluss-rust/issues/72
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
