luoyuxia commented on code in PR #57:
URL: https://github.com/apache/fluss-rust/pull/57#discussion_r2587166010
##########
crates/fluss/src/client/table/scanner.rs:
##########
@@ -298,7 +298,11 @@ impl LogFetcher {
} else {
let (projection_enabled, projected_fields) = match
self.read_context.project_fields() {
None => (false, vec![]),
- Some(fields) => (true, fields.iter().map(|&i| i as
i32).collect()),
+ Some(fields) => {
+ let mut sorted: Vec<i32> = fields.iter().map(|&i| i as
i32).collect();
Review Comment:
Maybe we can make read_context return project_fields_in_order? Make it as a
member of `Projection` to avoid build the sorted fields in each fetch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
