zhaohaidao commented on PR #57:
URL: https://github.com/apache/fluss-rust/pull/57#issuecomment-3605487931

   > @zhaohaidao Thanks for the pr. Left minor comments. PTAL. Also, seem this 
pr doesn't include reordeing the project fields returned by server for final 
output. See java impl 
https://github.com/apache/fluss/blob/ae84521aaaef5448a0bc5a63fc83e6ca536ca452/fluss-common/src/main/java/org/apache/fluss/record/LogRecordReadContext.java#L84
   > 
   > don't forget to create an issue to track it. It's critical when project 
fields is out of orders like [3, 2, 1]
   
   @luoyuxia Thank you for your concise and elegant suggestions. Comments are 
addressed. PTAL if u have time


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to