MehulBatra commented on code in PR #2043:
URL: https://github.com/apache/fluss/pull/2043#discussion_r2607528900
##########
fluss-lake/fluss-lake-iceberg/src/main/java/org/apache/fluss/lake/iceberg/IcebergLakeCatalog.java:
##########
@@ -249,6 +271,14 @@ private void setFlussPropertyToIceberg(
}
}
+ private static String convertFlussPropertyKeyToIceberg(String key) {
Review Comment:
If a user passes "iceberg." or "fluss." (just the prefix with no actual
property name)
This will attempt to set/remove a property with an empty key in Iceberg,
which could create invalid table metadata
wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
