MehulBatra commented on code in PR #2043:
URL: https://github.com/apache/fluss/pull/2043#discussion_r2607555541
##########
fluss-lake/fluss-lake-iceberg/src/main/java/org/apache/fluss/lake/iceberg/IcebergLakeCatalog.java:
##########
@@ -119,8 +122,27 @@ public void createTable(TablePath tablePath,
TableDescriptor tableDescriptor, Co
@Override
public void alterTable(TablePath tablePath, List<TableChange>
tableChanges, Context context)
Review Comment:
For primary key tables, Fluss automatically sets merge-on-read properties
for Iceberg table
eg: icebergProperties.put("write.delete.mode", "merge-on-read)
We should not allow user to change that for Primary key table I feel it was
set purposely how to merge data and delete files for reading, we can put a
check on that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
