nastra commented on code in PR #2043:
URL: https://github.com/apache/fluss/pull/2043#discussion_r2609940108
##########
fluss-lake/fluss-lake-iceberg/src/main/java/org/apache/fluss/lake/iceberg/IcebergLakeCatalog.java:
##########
@@ -249,6 +271,14 @@ private void setFlussPropertyToIceberg(
}
}
+ private static String convertFlussPropertyKeyToIceberg(String key) {
Review Comment:
I don't think table metadata would be invalid and Iceberg also doesn't
prevent against this case as can be seen in the impl:
https://github.com/apache/iceberg/blob/fe23584fc3af9f0ea1371989030b0a99affb233f/core/src/main/java/org/apache/iceberg/PropertiesUpdate.java#L50-L70
You would just end up with an empty table property that wouldn't do
anything, so I don't think we need to do any special casing here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
