xx789633 commented on code in PR #1937:
URL: https://github.com/apache/fluss/pull/1937#discussion_r2622350311
##########
fluss-flink/fluss-flink-common/src/test/java/org/apache/fluss/flink/catalog/FlinkCatalogFactoryTest.java:
##########
@@ -75,7 +76,12 @@ public void testCreateCatalog() {
securityMap.put("client.security.sasl.username", "root");
securityMap.put("client.security.sasl.password", "password");
+ Map<String, String> lakeCatalogMap = new HashMap<>();
Review Comment:
a new test `testCreateCatalogWithLakeProperties` is added.
##########
fluss-flink/fluss-flink-common/src/main/java/org/apache/fluss/flink/lake/LakeFlinkCatalog.java:
##########
@@ -69,12 +71,28 @@ public Catalog getLakeCatalog(Configuration tableOptions) {
+
ConfigOptions.TABLE_DATALAKE_FORMAT.key()
+ "' is set.");
}
+ String dataLakePrefix = lakeFormat.toString() + ".";
+ Map<String, String> catalogProperties =
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
