luoyuxia commented on code in PR #1937:
URL: https://github.com/apache/fluss/pull/1937#discussion_r2623272292
##########
fluss-flink/fluss-flink-common/src/main/java/org/apache/fluss/flink/catalog/FlinkCatalog.java:
##########
@@ -772,4 +785,9 @@ public Procedure getProcedure(ObjectPath procedurePath)
public Map<String, String> getSecurityConfigs() {
return securityConfigs;
}
+
+ @VisibleForTesting
+ public Supplier<Map<String, String>> getLakeCatalogProperties() {
Review Comment:
```suggestion
public Map<String, String> getLakeCatalogProperties() {
```
##########
fluss-flink/fluss-flink-2.1/src/main/java/org/apache/fluss/flink/catalog/Flink21Catalog.java:
##########
@@ -53,13 +61,15 @@ public Flink21Catalog(
String bootstrapServers,
ClassLoader classLoader,
Map<String, String> securityConfigs,
+ Supplier<Map<String, String>> lakeCatalogProperties,
Review Comment:
dito
##########
fluss-flink/fluss-flink-2.1/src/main/java/org/apache/fluss/flink/catalog/Flink21Catalog.java:
##########
@@ -42,8 +43,15 @@ public Flink21Catalog(
String defaultDatabase,
String bootstrapServers,
ClassLoader classLoader,
- Map<String, String> securityConfigs) {
- super(name, defaultDatabase, bootstrapServers, classLoader,
securityConfigs);
+ Map<String, String> securityConfigs,
+ Supplier<Map<String, String>> lakeCatalogProperties) {
Review Comment:
```suggestion
Supplier<Map<String, String>> lakeCatalogPropertiesSupplier) {
```
##########
fluss-flink/fluss-flink-common/src/main/java/org/apache/fluss/flink/catalog/FlinkCatalog.java:
##########
@@ -115,6 +116,7 @@ public class FlinkCatalog extends AbstractCatalog {
protected final String bootstrapServers;
protected final Map<String, String> securityConfigs;
protected final LakeFlinkCatalog lakeFlinkCatalog;
+ protected final Supplier<Map<String, String>> lakeCatalogProperties;
Review Comment:
dito
##########
fluss-flink/fluss-flink-common/src/main/java/org/apache/fluss/flink/catalog/FlinkCatalog.java:
##########
@@ -312,8 +318,12 @@ public CatalogBaseTable getTable(ObjectPath objectPath)
objectPath.getDatabaseName(),
tableName.split("\\" +
LAKE_TABLE_SPLITTER)[0])));
}
+
return getLakeTable(
- objectPath.getDatabaseName(), tableName,
tableInfo.getProperties());
+ objectPath.getDatabaseName(),
+ tableName,
+ tableInfo.getProperties(),
+ lakeCatalogProperties);
Review Comment:
nit: we can get in here directly
lakeCatalogProperties.get()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
