xx789633 commented on code in PR #1937:
URL: https://github.com/apache/fluss/pull/1937#discussion_r2623283685
##########
fluss-flink/fluss-flink-common/src/main/java/org/apache/fluss/flink/catalog/FlinkCatalog.java:
##########
@@ -312,8 +318,12 @@ public CatalogBaseTable getTable(ObjectPath objectPath)
objectPath.getDatabaseName(),
tableName.split("\\" +
LAKE_TABLE_SPLITTER)[0])));
}
+
return getLakeTable(
- objectPath.getDatabaseName(), tableName,
tableInfo.getProperties());
+ objectPath.getDatabaseName(),
+ tableName,
+ tableInfo.getProperties(),
+ lakeCatalogProperties);
Review Comment:
Acquiring the properties here will frequently invoke the supplier function
and bring some overhead. Actually, the properties are only needed when creating
the lake catalog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
