rionmonster commented on issue #2091:
URL: https://github.com/apache/fluss/issues/2091#issuecomment-3690536015

   @wuchong 
   
   I think you’re correct here. This proposed change is going to simply prevent 
cyclical exceptions, in this specific area, from bubbling up into Stack 
Overflow errors. It’s similar to the proposed fix on the Flink side as it 
ignores any exceptions that it’s previously seen, either in the suppression or 
causal chains. 
   
   To your point though, this may be completely unnecessary as Fluss itself 
isn’t continually propagating the errors (and causing the same problem). It’s 
sort of a safeguard to prevent that behavior, but with the fix being applied in 
Flink, we may be safe to say it’s been addressed in Flink 2.2 and not bother 
with this change.
   
   It’s really just a safeguard to prevent this _type_ of issue from rising up, 
not necessarily preventing this issue itself.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to