wuchong commented on PR #2296: URL: https://github.com/apache/fluss/pull/2296#issuecomment-3707588857
Hi @Prajwal-banakar, thank you for the contribution! Just a quick note: the test failure in `FlinkUnionReadPrimaryKeyTableITCase` has already been resolved by [PR #2295](https://github.com/apache/fluss/pull/2295). Regarding this PR, **`MAX` and `MIN` are not intended to support complex data types** such as `ARRAY`, `MAP`, or `ROW`. These types are **not orderable**, and therefore Fluss (like other engines such as Apache Spark and Flink) cannot define a consistent total ordering for them. As a result, using `MAX`/`MIN` on such columns should be disallowed. The FIP also declared the supported types of max/min: https://cwiki.apache.org/confluence/display/FLUSS/FIP-21%3A+Aggregation+Merge+Engine Moreover, the original issue [#2247](https://github.com/apache/fluss/issues/2247) was actually aimed at supporting **aggregation functions that *operate on* complex types**, for example, the `ARRAY_AGG` that returns an `ARRAY` type. As a gentle reminder: to avoid wasted effort, we encourage contributors to **discuss the design and scope with committers in the GitHub issue and request to be assigned *before* opening a PR**. This is part of our [official contribution process](https://fluss.apache.org/community/how-to-contribute/contribute-code/#discuss), which helps ensure alignment and smoother reviews. Thanks again for your engagement with Fluss! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
