Prajwal-banakar commented on PR #2296: URL: https://github.com/apache/fluss/pull/2296#issuecomment-3707807323
Hi @wuchong, Thank you for the detailed explanation! I now understand the reasoning behind not supporting MIN/MAX for complex types like ARRAY or ROW due to the lack of total ordering. I also appreciate the clarification on the original intent of #2247. As a beginner in the codebase, I'd like to help implement the early type validation you mentioned in TableDescriptorValidation#validateAggregationFunctionParameters. To make sure I stay on the right track: Should I pivot this PR to focus on adding those "fail-fast" validations and tests? Or would you prefer I close this PR and open a new one specifically for the validation logic? I will make sure to discuss design in the issue tracker moving forward to better align with the project's contribution process. Thanks for your patience! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
