platinumhamburg commented on PR #2296: URL: https://github.com/apache/fluss/pull/2296#issuecomment-3708797696
> One important point you raised and that we should address is **early type validation**. We should **fail fast during table creation** if an aggregation function is applied to an unsupported data type. Specifically, in: > > ```java > org.apache.fluss.server.utils.TableDescriptorValidation#validateAggregationFunctionParameters > ``` > > we should validate that the column type is within the supported data types for the given aggregation function. If not, we should throw a clear error immediately. **This validation also needs dedicated test coverage.** I think this is the missing thing in last pull request, right? @platinumhamburg Yes, the previous PR indeed missed the strict type validation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
