leekeiabstraction commented on code in PR #189:
URL: https://github.com/apache/fluss-rust/pull/189#discussion_r2713819902
##########
crates/fluss/src/client/table/scanner.rs:
##########
@@ -570,6 +571,16 @@ impl LogFetcher {
}
}
+ fn should_invalidate_bucket_leader(error: FlussError) -> bool {
+ matches!(
+ error,
+ FlussError::NotLeaderOrFollower
+ | FlussError::LeaderNotAvailableException
+ | FlussError::FencedLeaderEpochException
+ | FlussError::UnknownTableOrBucketException
Review Comment:
Should we consider invalidating on `InvalidCoordinatorException`?
##########
crates/fluss/src/client/table/scanner.rs:
##########
@@ -745,6 +758,9 @@ impl LogFetcher {
.into();
let error = FlussError::for_code(error_code);
+ if Self::should_invalidate_bucket_leader(error) {
Review Comment:
Should we consider having the check and invalidation in other places e.g.
sender or lookup?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
