luoyuxia commented on code in PR #189:
URL: https://github.com/apache/fluss-rust/pull/189#discussion_r2719683856


##########
crates/fluss/src/client/table/scanner.rs:
##########
@@ -745,6 +772,10 @@ impl LogFetcher {
                     .into();
 
                     let error = FlussError::for_code(error_code);
+                    if Self::should_invalidate_bucket_leader(error) {
+                        // TODO: Consider triggering leader invalidation from 
sender/lookup paths.
+                        metadata.invalidate_bucket_leader(&table_bucket);

Review Comment:
   The impact should be small.  If just invalid a single leader, it'll also 
trigger a table-level metadata update currently since it should touch the 
bucket without leader in next few fetch.
   And `invalidate_physical_table_meta` is align with java side and I think 
maybe it'll make code simpler.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to