luoyuxia commented on code in PR #189:
URL: https://github.com/apache/fluss-rust/pull/189#discussion_r2719449748
##########
crates/fluss/src/cluster/cluster.rs:
##########
@@ -77,23 +80,62 @@ impl Cluster {
.filter_map(|id| self.table_path_by_id.get(id))
.collect();
- let available_locations_by_path = self
- .available_locations_by_path
- .iter()
- .filter(|&(path, _)| !table_paths.contains(path))
- .map(|(path, locations)| (path.clone(), locations.clone()))
- .collect();
+ let (available_locations_by_path, available_locations_by_bucket) =
+ self.filter_bucket_locations_by_path(&table_paths);
- let available_locations_by_bucket = self
- .available_locations_by_bucket
+ Cluster::new(
+ self.coordinator_server.clone(),
+ alive_tablet_servers_by_id,
+ available_locations_by_path,
+ available_locations_by_bucket,
+ self.table_id_by_path.clone(),
+ self.table_info_by_path.clone(),
+ )
+ }
+
+ pub fn invalidate_physical_table_bucket_meta(
Review Comment:
```suggestion
pub fn invalidate_physical_table_meta(
```
##########
crates/fluss/src/client/table/scanner.rs:
##########
@@ -745,6 +772,10 @@ impl LogFetcher {
.into();
let error = FlussError::for_code(error_code);
+ if Self::should_invalidate_bucket_leader(error) {
+ // TODO: Consider triggering leader invalidation from
sender/lookup paths.
+ metadata.invalidate_bucket_leader(&table_bucket);
Review Comment:
can we just call `invalidate_physical_table_meta` directly, so that we can
remove `invalidate_bucket_leader` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
