luoyuxia commented on code in PR #217:
URL: https://github.com/apache/fluss-rust/pull/217#discussion_r2732027756
##########
crates/fluss/Cargo.toml:
##########
@@ -22,12 +22,13 @@ version = { workspace = true }
name = "fluss"
[features]
-default = ["storage-memory", "storage-fs", "storage-s3"]
-storage-all = ["storage-memory", "storage-fs", "storage-s3"]
+default = ["storage-memory", "storage-fs"]
Review Comment:
remove `storage-s3` from default which avoid oss users include it though
they don't need.
##########
crates/fluss/Cargo.toml:
##########
@@ -22,12 +22,13 @@ version = { workspace = true }
name = "fluss"
[features]
-default = ["storage-memory", "storage-fs", "storage-s3"]
-storage-all = ["storage-memory", "storage-fs", "storage-s3"]
+default = ["storage-memory", "storage-fs"]
+storage-all = ["storage-memory", "storage-fs", "storage-s3", "storage-oss"]
Review Comment:
for s3 users:
```
fluss = { version = "x.x", features = ["storage-s3"] }
```
for oss users
```
fluss = { version = "x.x", features = ["storage-oss"] }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
