fresh-borzoni commented on code in PR #217:
URL: https://github.com/apache/fluss-rust/pull/217#discussion_r2742336256
##########
crates/fluss/src/client/credentials.rs:
##########
@@ -401,7 +426,8 @@ mod tests {
let props = build_remote_fs_props(&credentials, &addition_infos);
assert_eq!(props.get("access_key_id"), Some(&"ak".to_string()));
- assert_eq!(props.get("secret_access_key"), Some(&"sk".to_string()));
+ assert_eq!(props.get("access_key_secret"), Some(&"sk".to_string()));
+ assert_eq!(props.get("security_token"), Some(&"token".to_string()));
Review Comment:
nit: dup assertion
##########
crates/fluss/src/client/credentials.rs:
##########
@@ -74,11 +78,20 @@ fn build_remote_fs_props(
"access_key_id".to_string(),
credentials.access_key_id.clone(),
);
+
+ // S3 specific configurations
props.insert(
"secret_access_key".to_string(),
credentials.access_key_secret.clone(),
);
+ // OSS specific configurations, todo: consider refactor it
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
