leekeiabstraction commented on code in PR #217:
URL: https://github.com/apache/fluss-rust/pull/217#discussion_r2742342049
##########
crates/fluss/src/client/credentials.rs:
##########
@@ -401,7 +426,8 @@ mod tests {
let props = build_remote_fs_props(&credentials, &addition_infos);
assert_eq!(props.get("access_key_id"), Some(&"ak".to_string()));
- assert_eq!(props.get("secret_access_key"), Some(&"sk".to_string()));
+ assert_eq!(props.get("access_key_secret"), Some(&"sk".to_string()));
+ assert_eq!(props.get("security_token"), Some(&"token".to_string()));
Review Comment:
Reads like the wrong line was removed as we have duplicate assert on
`security_token`? Should it be
```java
assert_eq!(props.get("secret_access_key"), Some(&"sk".to_string()));
assert_eq!(props.get("access_key_secret"), Some(&"sk".to_string()));
assert_eq!(props.get("security_token"), Some(&"token".to_string()));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
