fresh-borzoni commented on code in PR #313:
URL: https://github.com/apache/fluss-rust/pull/313#discussion_r2808242552
##########
bindings/python/src/config.rs:
##########
@@ -39,33 +39,35 @@ impl Config {
let value: String = item.1.extract()?;
match key.as_str() {
- "bootstrap.servers" => {
+ "bootstrap_servers" | "bootstrap.servers" => {
Review Comment:
the choice is between "use full path with client prefix and dots as
separator" or "just the same names as other bindings configs but with dots as
separator"
first - would help with pyFlink example, but confusing compared to other
clients, second - matches other clients, but wouldn't help with pyFlink example
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
