luoyuxia commented on code in PR #313:
URL: https://github.com/apache/fluss-rust/pull/313#discussion_r2808247197
##########
bindings/python/src/config.rs:
##########
@@ -39,33 +39,35 @@ impl Config {
let value: String = item.1.extract()?;
match key.as_str() {
- "bootstrap.servers" => {
+ "bootstrap_servers" | "bootstrap.servers" => {
Review Comment:
Thanks, I'd suggest to use "just the same names as other bindings configs
but with dots as separator" . For client prefix in Fluss java repo, IIRC, it's
used to distinguish with server-side config since client and server in same
code repo. I think it can improve user experience to remove client prefix.
@leekeiabstraction WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
