platinumhamburg commented on code in PR #3492: URL: https://github.com/apache/fluss/pull/3492#discussion_r3517899049
########## fluss-flink/fluss-flink-common/src/main/java/org/apache/fluss/flink/functions/bitmap/RbOrFunction.java: ########## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.fluss.flink.functions.bitmap; + +import org.apache.flink.table.functions.ScalarFunction; +import org.roaringbitmap.RoaringBitmap; + +import javax.annotation.Nullable; + +import java.io.IOException; + +/** + * {@code rb_or(left BYTES, right BYTES) -> BYTES} + * + * <p>Returns the bitwise OR (union) of two serialized {@link RoaringBitmap} values. If one argument + * is null, the other is returned as-is. Returns {@code null} only if both are null. + */ +public class RbOrFunction extends ScalarFunction { + + /** + * @param leftBytes serialized left bitmap + * @param rightBytes serialized right bitmap + * @return union of left and right, or null if both are null + */ + @Nullable + public byte[] eval(@Nullable byte[] leftBytes, @Nullable byte[] rightBytes) throws IOException { + if (leftBytes == null && rightBytes == null) { + return null; + } + if (leftBytes == null) { + return rightBytes; + } + if (rightBytes == null) { Review Comment: rb_or applies the aggregate-style NULL-as-ignored behavior to a scalar function. FIP-37 explicitly documents that rb_or_agg ignores NULL inputs, but also distinguishes NULL from empty bitmap. Unless scalar rb_or is specified to treat NULL as identity, this should probably return NULL when either argument is NULL, or the scalar NULL semantics need to be documented and tested. ########## fluss-flink/fluss-flink-common/src/main/java/org/apache/fluss/flink/functions/bitmap/RbBuildFunction.java: ########## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.fluss.flink.functions.bitmap; + +import org.apache.flink.table.functions.ScalarFunction; +import org.roaringbitmap.RoaringBitmap; + +import javax.annotation.Nullable; + +import java.io.IOException; + +/** + * {@code rb_build(v1 INT, v2 INT, ...) -> BYTES} + * + * <p>Builds a serialized {@link RoaringBitmap} from a variadic list of 32-bit integer values within + * a single row. Unlike {@code rb_build_agg}, this function operates on individual column values in + * the same row rather than aggregating across rows. Null values are ignored. Returns {@code null} + * if all inputs are null or no inputs are provided. + */ +public class RbBuildFunction extends ScalarFunction { + + /** + * @param values variadic integer values to add to the bitmap; null values are ignored + * @return serialized bitmap, or null if all inputs are null + */ + @Nullable + public byte[] eval(@Nullable Integer... values) throws IOException { Review Comment: It looks like the implementation does not match the advertised signature for `rb_build`. The PR description says `rb_build(ARRAY<INT>) -> BYTES`, but the UDF currently exposes: ```java public byte[] eval(@Nullable Integer... values) ``` In Flink UDF type inference, Java varargs are treated as a varying sequence of arguments rather than a single ARRAY argument. So this supports SQL like: ```sql rb_build(1, 2, 3) ``` but it is different from: ```sql rb_build(ARRAY[1, 2, 3]) ``` If the intended API is rb_build(ARRAY<INT>) -> BYTES, could we change the implementation to accept a non-varargs array/list-style parameter and add an SQL test for rb_build(ARRAY[1, 2, 3]) or an array column? Otherwise, the PR description and function Javadoc should document the variadic signature instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
