Prajwal-banakar commented on code in PR #3492: URL: https://github.com/apache/fluss/pull/3492#discussion_r3522687307
########## fluss-flink/fluss-flink-common/src/main/java/org/apache/fluss/flink/functions/bitmap/RbBuildFunction.java: ########## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.fluss.flink.functions.bitmap; + +import org.apache.flink.table.functions.ScalarFunction; +import org.roaringbitmap.RoaringBitmap; + +import javax.annotation.Nullable; + +import java.io.IOException; + +/** + * {@code rb_build(v1 INT, v2 INT, ...) -> BYTES} + * + * <p>Builds a serialized {@link RoaringBitmap} from a variadic list of 32-bit integer values within + * a single row. Unlike {@code rb_build_agg}, this function operates on individual column values in + * the same row rather than aggregating across rows. Null values are ignored. Returns {@code null} + * if all inputs are null or no inputs are provided. + */ +public class RbBuildFunction extends ScalarFunction { + + /** + * @param values variadic integer values to add to the bitmap; null values are ignored + * @return serialized bitmap, or null if all inputs are null + */ + @Nullable + public byte[] eval(@Nullable Integer... values) throws IOException { Review Comment: I've corrected the signature to align with the documented rb_build(ARRAY<INT>) behavior. The eval method now accepts Integer[], and I've added an integration test case in RbFunctionsCatalogITCase using rb_build(ARRAY[...]) to confirm it works as expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
