Prajwal-banakar commented on code in PR #3492: URL: https://github.com/apache/fluss/pull/3492#discussion_r3522686439
########## fluss-flink/fluss-flink-common/src/main/java/org/apache/fluss/flink/functions/bitmap/RbOrFunction.java: ########## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.fluss.flink.functions.bitmap; + +import org.apache.flink.table.functions.ScalarFunction; +import org.roaringbitmap.RoaringBitmap; + +import javax.annotation.Nullable; + +import java.io.IOException; + +/** + * {@code rb_or(left BYTES, right BYTES) -> BYTES} + * + * <p>Returns the bitwise OR (union) of two serialized {@link RoaringBitmap} values. If one argument + * is null, the other is returned as-is. Returns {@code null} only if both are null. + */ +public class RbOrFunction extends ScalarFunction { + + /** + * @param leftBytes serialized left bitmap + * @param rightBytes serialized right bitmap + * @return union of left and right, or null if both are null + */ + @Nullable + public byte[] eval(@Nullable byte[] leftBytes, @Nullable byte[] rightBytes) throws IOException { + if (leftBytes == null && rightBytes == null) { + return null; + } + if (leftBytes == null) { + return rightBytes; + } + if (rightBytes == null) { Review Comment: I've updated rb_or to return NULL if either input is NULL, aligning it with standard SQL behavior for scalar functions. The corresponding unit tests have been updated to verify this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
