MehulBatra commented on code in PR #2699:
URL: https://github.com/apache/fluss/pull/2699#discussion_r3523835581
##########
website/docs/streaming-lakehouse/integrate-data-lakes/_category_.json:
##########
@@ -1,4 +0,0 @@
-{
Review Comment:
Thanks for catching this, you're right that the renamed pages need
redirects. I ended up using the existing createRedirects function rather than
an explicit redirects: [{from, to}] array, because the explicit form breaks
the build today, and I wanted to explain why.
The renamed layout only exists in next (1.0-SNAPSHOT). The unversioned
/docs/... URLs still
resolve to 0.9, which keeps the old structure. So right now an explicit
redirect fails on both
ends: its to: target (the new path) doesn't exist yet, so
plugin-client-redirects throws
"these paths are redirected to but do not exist", and its from: path is
still a live 0.9 page,
so the plugin would skip it anyway to avoid shadowing a real route.
The old URLs only start 404ing once this restructure becomes the latest
release (when 1.0
replaces 0.9 as the unversioned latest). Old versions themselves (0.6–0.9)
keep working and
need no redirects.
So instead of hardcoding redirects that would either break the build now or
need to be
remembered at 1.0 release time, I added the rename mapping into
createRedirects:
```
const renameRules = [
{ from: '/maintenance/filesystems/', to:
'/maintenance/tiered-storage/filesystems/' },
{ from: '/streaming-lakehouse/integrate-data-lakes/formats/', to:
'/streaming-lakehouse/datalake-formats/' },
{ from: '/streaming-lakehouse/integrate-data-lakes/catalogs/', to:
'/streaming-lakehouse/datalake-catalogs/' },
];
```
Because createRedirects keys off routes that actually exist, the target is
always valid, and
each old→new redirect activates exactly when the restructured docs become
the latest release —
i.e. precisely when the old URL would otherwise 404. It's build-safe today
and covers every
leaf page under the three moved folders automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
