luoyuxia commented on code in PR #2699:
URL: https://github.com/apache/fluss/pull/2699#discussion_r3524194302


##########
website/docs/streaming-lakehouse/datalake-formats/iceberg.md:
##########


Review Comment:
   Line 265: Could we fix this option name while reorganizing the docs? 
`table.datalake.auto-maintenance` does not exist in `ConfigOptions`; the 
available table-level options are `table.datalake.auto-compaction` and 
`table.datalake.auto-expire-snapshot`. Users copying this example would think 
maintenance is enabled while the option is not a valid Fluss option. For this 
example, I think we should either remove the line or change it to 
`table.datalake.auto-compaction` if compaction is intended.



##########
website/docs/streaming-lakehouse/datalake-formats/paimon.md:
##########


Review Comment:
   Line 185: This page still has a broken relative link to Fluss data types: 
`table-design/data-types.md` resolves under 
`streaming-lakehouse/datalake-formats/`. The target is 
`website/docs/table-design/data-types.md`, so this should be 
`../../table-design/data-types.md`.



##########
website/docs/streaming-lakehouse/datalake-formats/lance.md:
##########


Review Comment:
   Line 128: Same broken relative link here: `table-design/data-types.md` 
resolves under `streaming-lakehouse/datalake-formats/`, while the actual target 
is `website/docs/table-design/data-types.md`. Please change it to 
`../../table-design/data-types.md`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to